Skip to content

Replace hardcoded GitHub URL in bump-version skill#127

Merged
igerber merged 1 commit intomainfrom
skill-repo-review
Feb 1, 2026
Merged

Replace hardcoded GitHub URL in bump-version skill#127
igerber merged 1 commit intomainfrom
skill-repo-review

Conversation

@igerber
Copy link
Owner

@igerber igerber commented Feb 1, 2026

Summary

  • Replace hardcoded igerber/diff-diff URL in .claude/commands/bump-version.md with dynamic resolution via git remote get-url origin
  • The CHANGELOG comparison link template now uses OWNER/REPO placeholders with instructions to derive them from the remote, matching the pattern used by other skills (e.g., submit-pr.md)

Methodology references (required if estimator / math changes)

  • N/A - no methodology changes

Validation

  • Tests added/updated: No test changes (skill markdown file only)
  • Verified with grep -r "igerber" .claude/commands/ returning no results after the fix

Security / privacy

  • Confirm no secrets/PII in this PR: Yes

Generated with Claude Code

…ution

The CHANGELOG comparison link in bump-version.md hardcoded
igerber/diff-diff, which would produce incorrect links for forks.
Now instructs Claude to derive owner/repo from git remote, matching
the pattern used by other skills.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Feb 1, 2026

Overall assessment: ✅ Looks good

Executive summary

  • Documentation-only change; no estimator/methodology impact.
  • New instruction assumes origin is a GitHub remote; add fallback guidance for non-GitHub/missing origin.
  • No tests updated, which is fine for a skill markdown change.

Methodology

  • No findings. This PR does not touch estimators, math, or assumptions.

Code Quality

  • No findings.

Performance

  • No findings.

Maintainability

  • No findings.

Tech Debt

  • No findings.

Security

  • No findings.

Documentation/Tests

  • Severity: P3
    Impact: The instructions could mislead or fail if origin is missing or points to a non‑GitHub host (e.g., GitLab), leading to incorrect CHANGELOG links.
    Concrete fix: Add a short fallback note to verify the host and allow manual OWNER/REPO entry when origin isn’t GitHub or is absent.
    Location: .claude/commands/bump-version.md:L78-L96

@igerber igerber merged commit 1ce4230 into main Feb 1, 2026
1 check passed
@igerber igerber deleted the skill-repo-review branch February 1, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant